-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: improve estimation for index equal con ... (#17366) #17611
Merged
zz-jason
merged 3 commits into
pingcap:release-4.0
from
sre-bot:release-4.0-94a722e2df8d
Jun 3, 2020
Merged
statistics: improve estimation for index equal con ... (#17366) #17611
zz-jason
merged 3 commits into
pingcap:release-4.0
from
sre-bot:release-4.0-94a722e2df8d
Jun 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
/run-all-tests |
sre-bot
added
sig/planner
SIG: Planner
component/statistics
type/4.0-cherry-pick
type/enhancement
The issue or PR belongs to an enhancement.
labels
Jun 3, 2020
zz-jason
reviewed
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lzmhhh123
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eurekaka
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Jun 3, 2020
/run-all-tests |
/run-integration-copr-test |
@sre-bot merge failed. |
/run-integration-copr-test |
/run-integration-br-test |
zz-jason
changed the title
statistics: improve estimation for index equal condition (#17366)
statistics: improve estimation for index equal con ... (#17366)
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/statistics
sig/planner
SIG: Planner
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/enhancement
The issue or PR belongs to an enhancement.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17366 to release-4.0
What problem does this PR solve?
Issue Number: close #17364
Problem Summary:
Wrong plan is chosen when index equal condition contains value which is out of the range of the histogram.
What is changed and how it works?
What's Changed:
Compute the NDV for the prefix columns of the index which are used for equal condition, and use it for row count guess.
How it Works:
It is more reasonable than hard-coded constant
outOfRangeBetweenRate
.Related changes
N/A
Check List
Tests
Side effects
N/A
Release note